Repository navigation
Conversation
Signed-off-by: Adam Magued <adamismailmageud@gmail.com>
AdamMagued
force-pushed
the
fix/issue-875-cpuinfo-arm64-parser-ignores-c
branch
from
October 17, 2026 03:49
3c165a7 to
e6b3490
Compare
SuperQ
reviewed
Oct 19, 2026
Fix linting issue Signed-off-by: Ben Kochie <superq@gmail.com>
SuperQ
reviewed
Oct 19, 2026
Comment on lines
+235
to
+244
| updateStepping := func(idx int) { | ||
| v := variants[idx] | ||
| r := revisions[idx] | ||
| stepping := formatSteppingARM(v, r) | ||
| if idx == -1 { | ||
| commonCPUInfo.Stepping = stepping | ||
| } else { | ||
| cpuinfo[idx].Stepping = stepping | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
I'm not a big fan of this inline function. Is there a cleaner way to handle this?
Contributor
Author
There was a problem hiding this comment.
Refactored to eliminate the inline closure completely. Variant and revision values are captured directly during scanning and stepping formatting is resolved in a single post-scanning pass across the parsed entries. Verified clean against unit tests and go vet.
Resolve ARM stepping values per core in a single post-scanning pass rather than invoking an inline closure repeatedly inside the scanner loop. Signed-off-by: Adam Magued <adamismailmageud@gmail.com>
Member
rtreffer
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #875.